-
Notifications
You must be signed in to change notification settings - Fork 176
Allow test files to have different extensions with transform #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ldesplat
commented
Mar 6, 2015
- Since we specify transform, our tests themselves could be transformed.
- Document a pitfall, which is to not transform too many files so the user has to check for that in transform method.
…ransform. Document potential pitfall
README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be ===
lib/cli.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will create a wrong regex ( .(js|)$ ) if the transform module exports an empty array. Also, the dot should be escaped, below and above too.
…s not empty before building a new regex.
|
Thank you so much @gergoerdosi for spotting those issues. I have fixed the code review issues and file extensions can now include some crazy stuff :). Tested a whole bunch of special characters on Mac, quite interesting! |
|
@ldesplat do we need any new tests for any of the edge cases you were considering with this change? |
|
don't merge |
|
Ok, I am sorry. All should be well now. Thanks for telling me to add tests. I had to resort to way too many PRs to add this feature in. Next time I'll hold on a bit longer no matter my enthusiasm! Thanks for all your support. |
|
@ldesplat thanks for all the effort to add this feature! |
Allow test files to have different extensions with transform
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |