-
Notifications
You must be signed in to change notification settings - Fork 176
Add ESLint rule for blank line at beginning of function scope #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👍 Shouldn't we create a single module for all hapi-related rules ? One module per rule seems overkill. |
|
Also, wouldn't it be better to release it as an ESLint plugin ? |
|
This was the only rule that @geek brought to my attention. What else is missing/not natively supported by ESLint? |
|
There were a few when I first implemented ESLint into lab, maybe it changed. I'll try to put up a list someday. |
|
@cjihrig I love the rule! But can you make it into a plugin so I can use it in other projects (without using cli params) (see eslint/eslint#2180) |
|
I'll look into creating a plugin today. |
|
@cjihrig cool thanks! |
|
Converted to a plugin |
|
@cjihrig thanks I will definitely use this! |
|
👍 |
Add ESLint rule for blank line at beginning of function scope
|
@geek I'm not familiar with the release cycle for lab, but when do you think this 5.5.2 will be pushed to npm? |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
The rule causes warnings if the blank line is missing. Testing turned up a couple places where the blank line was missing in lab.