Skip to content

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Apr 8, 2015

The rule causes warnings if the blank line is missing. Testing turned up a couple places where the blank line was missing in lab.

@Marsup
Copy link
Contributor

Marsup commented Apr 8, 2015

👍 Shouldn't we create a single module for all hapi-related rules ? One module per rule seems overkill.

@Marsup
Copy link
Contributor

Marsup commented Apr 8, 2015

Also, wouldn't it be better to release it as an ESLint plugin ?

@cjihrig
Copy link
Contributor Author

cjihrig commented Apr 8, 2015

This was the only rule that @geek brought to my attention. What else is missing/not natively supported by ESLint?

@Marsup
Copy link
Contributor

Marsup commented Apr 8, 2015

There were a few when I first implemented ESLint into lab, maybe it changed. I'll try to put up a list someday.

@AdriVanHoudt
Copy link
Contributor

@cjihrig I love the rule! But can you make it into a plugin so I can use it in other projects (without using cli params) (see eslint/eslint#2180)

@cjihrig
Copy link
Contributor Author

cjihrig commented Apr 13, 2015

I'll look into creating a plugin today.

@AdriVanHoudt
Copy link
Contributor

@cjihrig cool thanks!

@cjihrig
Copy link
Contributor Author

cjihrig commented Apr 13, 2015

Converted to a plugin

@AdriVanHoudt
Copy link
Contributor

@cjihrig thanks I will definitely use this!

@cjihrig
Copy link
Contributor Author

cjihrig commented Apr 13, 2015

👍

@geek geek added the feature New functionality or improvement label Apr 13, 2015
@geek geek added this to the 5.5.2 milestone Apr 13, 2015
@geek geek self-assigned this Apr 13, 2015
geek added a commit that referenced this pull request Apr 13, 2015
Add ESLint rule for blank line at beginning of function scope
@geek geek merged commit c621a3a into hapijs:master Apr 13, 2015
@tielur
Copy link
Contributor

tielur commented Apr 14, 2015

@geek I'm not familiar with the release cycle for lab, but when do you think this 5.5.2 will be pushed to npm?

@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature New functionality or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants