Fix HTML reporter when using live-transformed code #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with html reporter
Contributor
|
Thanks so much 🙏 |
geek
added a commit
that referenced
this pull request
Apr 20, 2015
Fix HTML reporter when using live-transformed code
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow the HTML reporter (and others) to display the transformed code. The display now makes much more sense, and the right lines are highlighted.
@jedireza raised this earlier this week along.
@romeovs raised it too in issue #338 but this does not fix 338. Though it does fix the weird line numbers (line 1 being repeated) raised later on!
Before, it would have highlighted an irrelevant line like so
