Skip to content

Conversation

@Marsup
Copy link
Contributor

@Marsup Marsup commented Apr 25, 2015

On my way I un-ignored test files, it seems important that they go through linting as well.
Since we're out of short handles for CLI, well, none.

@AdriVanHoudt
Copy link
Contributor

👍 I like that tests can fail on linting, will make PR's so much easier.

@AdriVanHoudt
Copy link
Contributor

There is still b, q, j, k, u :P those don't really make sense but if timeout can have -m...
Also I should not read PR's at 10am in the weekend :D @Marsup

@geek geek added this to the 5.7.1 milestone Apr 27, 2015
@geek geek added the feature New functionality or improvement label Apr 27, 2015
@geek geek self-assigned this Apr 27, 2015
@geek
Copy link
Member

geek commented Apr 27, 2015

@Marsup well done, this looks solid.

geek added a commit that referenced this pull request Apr 27, 2015
@geek geek merged commit 9e53e14 into hapijs:master Apr 27, 2015
@Marsup Marsup deleted the lint-thresholds branch December 18, 2015 19:45
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature New functionality or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants