Enforce capitalization of imported module variable names #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/cli.js
Outdated
Contributor
There was a problem hiding this comment.
Can't we only enforce this rule on module global variables?
Contributor
Author
There was a problem hiding this comment.
I'll look into it. It should be possible by inspecting parent nodes.
Contributor
Author
|
@hueniverse I added an option to the rule to only target assignments in the module's global scope. |
Contributor
|
@cjihrig that should be the default so we don't need all these exception comments above. |
Contributor
Author
|
Yep, it is now :-) |
geek
added a commit
that referenced
this pull request
Jun 9, 2015
Enforce capitalization of imported module variable names
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the style guide: