Skip to content

Conversation

@AdriVanHoudt
Copy link
Contributor

Another eslint, another PR (until v1 :P)

  • updated eslint to 0.23
  • added space after comment rule, except when followed by , to allow comments for optional function params like function (title /*, options, fn */)

@AdriVanHoudt
Copy link
Contributor Author

hmm tests fail because

lib/reporters/console.js:
        Line 43: space-unary-ops - Unary word operator "this" must be followed by whitespace.

And actually doing this .count++; does not fail any tests, weird

@geek geek added the dependency Update module dependency label Jun 23, 2015
@geek geek self-assigned this Jun 23, 2015
@geek geek added this to the 5.11.1 milestone Jun 23, 2015
@AdriVanHoudt
Copy link
Contributor Author

I talked to the people of eslint (see linked issue) and a fix will probably land this weekend so I would hold off on this PR until then, either we jump 2 releases or an extra patch, both are nice

@geek geek removed this from the 5.11.1 milestone Jun 25, 2015
@geek geek modified the milestone: 5.11.2 Jun 30, 2015
@AdriVanHoudt
Copy link
Contributor Author

@geek how do you want me to proceed? update the pr with #387 and just add the new rule, make a new pr with the rule or just close if you don't want the rule

@geek
Copy link
Member

geek commented Jul 1, 2015

I would update the PR with the new rule... delete the change to package.json and it should merge. Right?

@AdriVanHoudt
Copy link
Contributor Author

My rebase skills are not top notch :P but it works, will try to squash

@AdriVanHoudt
Copy link
Contributor Author

ok that's better ^^ force push 🎉

@geek
Copy link
Member

geek commented Jul 1, 2015

@AdriVanHoudt can't beat a good force push

@geek geek added this to the 5.11.2 milestone Jul 1, 2015
geek added a commit that referenced this pull request Jul 1, 2015
updated eslint to 0.23.x from 0.22.x
@geek geek merged commit c86ae5c into hapijs:master Jul 1, 2015
@geek geek changed the title updated eslint to 0.23.x from 0.22.x Added space after comment rule Jul 1, 2015
@geek geek added feature New functionality or improvement and removed dependency Update module dependency labels Jul 1, 2015
@AdriVanHoudt
Copy link
Contributor Author

@geek the one advantage in the war with git 💪 😄

@AdriVanHoudt AdriVanHoudt deleted the eslint23 branch July 1, 2015 20:47
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature New functionality or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants