-
Notifications
You must be signed in to change notification settings - Fork 176
Added space after comment rule #381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
hmm tests fail because lib/reporters/console.js:
Line 43: space-unary-ops - Unary word operator "this" must be followed by whitespace.And actually doing |
|
I talked to the people of eslint (see linked issue) and a fix will probably land this weekend so I would hold off on this PR until then, either we jump 2 releases or an extra patch, both are nice |
|
I would update the PR with the new rule... delete the change to package.json and it should merge. Right? |
|
My rebase skills are not top notch :P but it works, will try to squash |
|
ok that's better ^^ force push 🎉 |
|
@AdriVanHoudt can't beat a good force push |
updated eslint to 0.23.x from 0.22.x
|
@geek the one advantage in the war with git 💪 😄 |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Another eslint, another PR (until v1 :P)
,to allow comments for optional function params likefunction (title /*, options, fn */)