Do not add tracking code before "var" in "for(var x of xs)" #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 26, 2015 08:56
…e for-of
I got numbers in test/coverage.js (percent, sloc & hits) by first adding
another for-in loop into partial.js below the existing one:
for (var o in j) {
++l;
}
When the test worked and 100% code coverage was achieved, the loop was
changed to for (var o of j)
This occurs when this is true: node.type == "VariableDeclaration" node.parent.type == "ForOfStatement" Fixes issue hapijs#470
Contributor
|
LGTM. As for CI, maybe next lab should be node 4+. |
Member
|
@Marsup I think you are onto a good plan. I will work on ironing out the details and see about making lab 7 be node 4+ |
geek
added a commit
that referenced
this pull request
Oct 27, 2015
Do not add tracking code before "var" in "for(var x of xs)"
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #470
Do not add tracking code before
varinfor(var x of xs)This occurs when this is true:
This PR includes new code in
partial.js(as this was where I foundfor(var x in xs)) which is used in a test incoverage.js.I hope this was the correct place to add it.