Feature/silent skips #544
Merged
Feature/silent skips #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@rluba well done! |
Contributor
|
👍 This is the kind of PR that reminds me we should really consider having a |
Contributor
Author
|
@Marsup Yeah, it was not easy to find a free shortcut for the new option — already a pretty long list 😕 |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’ve implemented a
silent-skipsoption to reduce the noise when using.onlyin large test suites. I hope you like it.With this in place, we could also remove the special case for
ids/glob(see bullet 2 in myonlyPR and @geek’s response) since the "noisy output" can now be prevented by adding-kwhen usingids/glob.This PR also fixes
todotests being reported ascompleteat the end – even though they are displayed as skipped (-) in the output itself. I caught this by accident when writing the test for the new feature.mastercurrently contains some uncovered lines from #541 sonpm testfails atm.