Skip to content

Conversation

@krisb
Copy link
Contributor

@krisb krisb commented Mar 23, 2014

Adds spec style form output

Incorporates #53 and #55 also

@krisb
Copy link
Contributor Author

krisb commented Mar 27, 2014

@hueniverse: rebased onto master (2.0.1). Any chance of looking at pulling this or giving me some feedback on it. Thanks.

@hueniverse
Copy link
Contributor

This is a pretty intrusive change. Are all those change required to make this work? Also why incorporate two other pull requests into one? It only makes it harder for me to figure out what is going on... Can we please focus on one change at a time :-) I usually get to review these very late in the day so you need to make it easy for my fried brain to follow...

krisb added 5 commits March 29, 2014 17:39
* added more information about experiments inline with tests
* experiments and tests now have a reference to their parent
* execute tests and experiments as a tree rather than list
* emit start, startExperiment, and endExperiment events
* queried potential issue with deep nested tests and beforeEach/afterEach
@krisb krisb closed this Mar 29, 2014
@krisb
Copy link
Contributor Author

krisb commented Mar 29, 2014

Clicked the wrong button

@krisb krisb reopened this Mar 29, 2014
@hueniverse hueniverse added this to the 2.1.0 milestone Mar 29, 2014
@hueniverse hueniverse self-assigned this Mar 29, 2014
@hueniverse
Copy link
Contributor

This turned out to be more intrusive than I wanted. Also decided to refactor the reporter file to make new reporter easier. Thanks for the work though.

@hueniverse hueniverse closed this Mar 29, 2014
@krisb krisb deleted the spec branch April 23, 2014 11:46
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature New functionality or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants