Don't execute before/after on experiments that lack tests #584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/runner.js
Outdated
| state.domains = []; | ||
|
|
||
| const skipExperiment = skip || experiment.options.skip; | ||
| const skipExperiment = skip || experiment.options.skip || !internals.experirementHasTests(experiment, state); |
Contributor
There was a problem hiding this comment.
experiment is spelt wrong.
lib/runner.js
Outdated
| } | ||
| }); | ||
|
|
||
| return tests.length; |
Contributor
There was a problem hiding this comment.
You should probably convert this to a Boolean before returning. "has tests" implies to me that it would be a Boolean.
|
|
||
| internals.experimentHasTests = function (experiment, state) { | ||
|
|
||
| if (experiment.experiments.length) { |
Contributor
There was a problem hiding this comment.
purely personal opinion but I find > 0 more clear as to what you are doing, just a fyi
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #337
Closes #440