Support .labrc.js for configuration #601
Conversation
test/run_cli.js
Outdated
| module.exports = (args, callback, root) => { | ||
|
|
||
| const cli = ChildProcess.spawn('node', [].concat(internals.labPath, args), { 'cwd' : root ? root : '.' }); | ||
| const cli = ChildProcess.spawn('node', [].concat(internals.labPath, args), { cwd : root ? root : '.' }); |
There was a problem hiding this comment.
While you're here... root ? root : '.' could just be root || '.' I think.
|
Maybe I'm missing something, but where do I look to see what options are supported by this new file? Are the config options just the name of the long command line flags without the |
|
I will update the readme to make it clearer what the allowed options are. They are the same long names as the cli options. |
|
Do you think we should be able to provide our own labrc or do you prefer a base labrc overridden through cli ? |
|
@geek I didn't mean that. You always have multiple test configuration, how do you intend to deal with that + rc ? |
|
@Marsup the first one found closest to the heart of the project wins.
|
|
LGTM |
|
Quick note: The removed default for |
|
@yelworc thanks for the report. I will investigate the issue, it shouldn't have happened because there is a default environment set in the runner https://github.com/hapijs/lab/blob/master/lib/runner.js#L40 |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Closes #598