Ignore while a promise returns inside a test with a value. Only watch for rejection #701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marsup
requested changes
May 1, 2017
lib/runner.js
Outdated
| itemResult.then instanceof Function) { | ||
|
|
||
| itemResult.then(done, done); | ||
| itemResult.then(() => { |
Contributor
There was a problem hiding this comment.
Just itemResult.then(() => done(), done).
Contributor
Author
|
@Marsup Your suggested change seems to have caused 2 other tests to fail. Thoughts? |
Contributor
|
Your change doesn't look remotely similar to my suggestion :) |
… for rejection Simplify Try again
Marsup
approved these changes
May 1, 2017
Contributor
|
Thanks ! I'll let @geek merge and release as it's not mine to make. |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #700 by adding a new test for a resolving promise and then updating the runner to ignore resolved values. Let me know if there are any changes you want me to make :)