Skip to content

Conversation

@jtlapp
Copy link
Contributor

@jtlapp jtlapp commented Sep 25, 2017

This is a PR for issue #759. Also appended LFs to error messages that cli.js outputs to options.output so that the shell prompt lands on the following line.

@jtlapp
Copy link
Contributor Author

jtlapp commented Sep 25, 2017

A decision still needs to be made about the appropriate exit code. If it should be zero, then the reporter test case cited in #759 will fail (and apparently for the wrong reasons).

@jtlapp
Copy link
Contributor Author

jtlapp commented Sep 25, 2017

An alternative solution would pull the missing file name out of the error message, so that lab would properly report files in subdirectories that get deleted in the middle of a test run (under very specific circumstances). I was less comfortable with creating a dependency on the form of the error message. The only other option adds complexity to the traverse() function.

The present implementation seemed like a reasonable compromise of probability and simplicity.

@jtlapp
Copy link
Contributor Author

jtlapp commented Sep 25, 2017

Hold on. I thought of a simple fix that shows even files deleted mid-test. Mod coming...

@jtlapp
Copy link
Contributor Author

jtlapp commented Sep 25, 2017

That should do it.

@geek geek self-requested a review September 26, 2017 14:44
@geek geek self-assigned this Sep 26, 2017
@geek geek added the bug Bug or defect label Sep 26, 2017
@geek geek added this to the 14.3.2 milestone Sep 26, 2017
@geek
Copy link
Member

geek commented Sep 26, 2017

@jtlapp thanks, this will be included in the next release.

@geek geek merged commit 97cea60 into hapijs:master Sep 26, 2017
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Bug or defect

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants