Skip to content

Conversation

@corbinu
Copy link
Contributor

@corbinu corbinu commented Dec 9, 2017

I merged in my typings and updated for the new use of async/await.

I also removed the Expect typings. They can be added back in however given that other assertion libraries can be used I think there are two better options:

  1. Currently I simply import expect from code separately and then use the @typings/code package. I have some enhancements I can simply commit to there.
  2. We could merge typings into code as well and import those.

Would love to get peoples thoughts on which is better

@geek
Copy link
Member

geek commented Dec 9, 2017

@corbinu I'd vote for 2 to get the code typings in.

@geek geek added the lts Backport for maintained old version label Dec 9, 2017
@geek geek self-assigned this Dec 9, 2017
@geek geek added this to the 15.1.3 milestone Dec 9, 2017
@geek geek merged commit d971304 into hapijs:master Dec 9, 2017
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lts Backport for maintained old version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants