TS: Uses an inferred generic on flags.mustCall #954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggoodman
commented
Dec 20, 2019
| * @returns a wrapped function. | ||
| */ | ||
| mustCall(func: Function, count: number): Function; | ||
| mustCall<T extends (...args: any[]) => any>(func: T, count: number): T; |
Contributor
Author
There was a problem hiding this comment.
This might impose some version constraints on the typescript version that can consume the typing info.
Contributor
There was a problem hiding this comment.
We only support latest TS versions. Is this a breaking change or not because it wasn't working to begin with?
Contributor
Author
There was a problem hiding this comment.
Hi, sorry I didn't get back earlier. I agree with your assessment; this should be treated as a bugfix IMHO because it produces a more correct typing result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the type of the function returned by
flags.mustCalldid not match the type of the function being passed in. As a result, attempts to use the function returned byflags.mustCallwould lack type safety.