This repository was archived by the owner on Sep 21, 2023. It is now read-only.
Add a new condition in workflow #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! If you are following the Terraform Cloud Get Started tutorial, please open the PR against your personal fork of this repository. We will automatically close this PR, but if you intended to edit the example itself please feel free to re-open it. |
Closed
im2nguyen
approved these changes
Apr 26, 2021
Contributor
im2nguyen
left a comment
There was a problem hiding this comment.
This looks good. Small suggestion that addresses the concern you brought up (most people won't be able to re-open PR)
Co-authored-by: Tu Nguyen <[email protected]>
Contributor
Author
|
commenting would work, sounds good. feel free to merge, I don't have write access ;) |
Contributor
|
Thanks @andrekolodochka! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current workflow will automatically close all pull requests. While I understand that it's a desired outcome in the original hashicorp/tfc-guide-example repository, this is not what you'd want in the forked repos. PRs in forked repos will be used to initiate Terraform runs, so they shouldn't be closed automatically.
I've added a condition to the workflow to only close PRs in hashicorp/tfc-guide-example repository.