adding the warnig and deprecated pragmas for ciphersuite. #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👍 for not deprecating ciphersuite_all that has its use. I think we should remove ciphersuite_medium from tls-debug in that same PR. |
Collaborator
Author
|
Done. |
ocheron
approved these changes
Apr 28, 2017
Contributor
ocheron
left a comment
There was a problem hiding this comment.
After merging I think it deserves an entry in the CHANGELOG.
And also better emphasis of ciphersuite_default in existing entry about sha384 ciphers.
9f0030a to
cc917a7
Compare
kazu-yamamoto
added a commit
to kazu-yamamoto/hs-tls
that referenced
this pull request
Apr 28, 2017
Collaborator
Author
Done. |
Collaborator
Author
I don't understand this. Would you resolve it by yourself? |
Contributor
|
Done in e368369. |
Collaborator
Author
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step for #153.