Skip to content

Conversation

@ocheron
Copy link
Contributor

@ocheron ocheron commented Jun 30, 2019

The project has most of what is necessary to handle fragmented packets except 2 things that are missing:

  • the recvPacket functions may return an empty result instead of continuing receiving, which causes failures in the handshake state machine
  • packets are not fragmented when sending

ocheron added 3 commits June 30, 2019 09:09
Maximum value for TLSCiphertext.length is 2^14 + 256.  See RFC 8446
section 5.2.  Contrary to previous versions, TLS 1.3 has less
expansion because there is no compression.
@kazu-yamamoto kazu-yamamoto self-requested a review July 1, 2019 02:34
Copy link
Collaborator

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kazu-yamamoto added a commit to kazu-yamamoto/hs-tls that referenced this pull request Jul 1, 2019
@kazu-yamamoto
Copy link
Collaborator

Rebased and merged.

@ocheron ocheron deleted the fragments branch July 2, 2019 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants