Manually define sconcat to use the efficient concat function #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Nice
|
Contributor
Author
Member
|
@gwils do you mind rebasing this? :-) |
Contributor
Author
|
Done. This is no longer blocked by merge conflicts :) |
sjakobi
approved these changes
Dec 18, 2019
Member
sjakobi
left a comment
There was a problem hiding this comment.
Nice! 👍
I hope this gets merged soon, once the new merge conflict has been resolved! :)
Contributor
|
@gwils could you please-please-please rebase it once more? ;) |
Contributor
Author
|
Done. You'd better merge it quickly, otherwise I'll be back here to rebase it again in 2021 :) |
Contributor
Author
|
Pushed again to hopefully fix CI... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.