Skip to content

Optimize inner loop of packUptoLenBytes and packUptoLenChars #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Bodigrim merged 1 commit into from
Oct 7, 2020
Merged

Optimize inner loop of packUptoLenBytes and packUptoLenChars #292

Bodigrim merged 1 commit into from
Oct 7, 2020

Conversation

@ethercrow
Copy link
Contributor

@ethercrow ethercrow commented Sep 30, 2020

This implements the second point from #55

Bodigrim
Bodigrim reviewed Sep 30, 2020
View reviewed changes
@Bodigrim Bodigrim requested a review from sjakobi October 6, 2020 18:28
sjakobi
sjakobi approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Bodigrim Bodigrim added this to the 0.11.1.0 milestone Oct 7, 2020
@Bodigrim Bodigrim merged commit 14ebbc5 into haskell:master Oct 7, 2020
@Bodigrim
Copy link
Contributor

Bodigrim commented Oct 7, 2020

Thanks, merged!

@Bodigrim Bodigrim linked an issue Oct 7, 2020 that may be closed by this pull request
Optimise Data.ByteString.Lazy.pack #55
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bodigrim Bodigrim Bodigrim approved these changes

@sjakobi sjakobi sjakobi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.11.1.0

Development

Successfully merging this pull request may close these issues.

Optimise Data.ByteString.Lazy.pack

3 participants

@ethercrow @Bodigrim @sjakobi