Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As dicovered in #311, certain tests fail for Windows build with GHC 8.10:
DeleteFile "\\\\?\\D:\\a\\bytestring\\bytestring\\tests\\qc-test-ThreadId 5": permission denied (The process cannot access the file because it is being used by another process.), emitted bySystem.Directory.removeFile, invoked inProperties.hs.bytestring/tests/Properties.hs
Lines 1609 to 1616 in a83b778
It's actually amazing that these tests have worked for ages under all other platforms, because they are reference examples of lazy I/O done wrong. Clearly the file is unlinked before its content is read in full. And
bracketis useless here, because there is no resource to capture. One must explicitly force evaluation of lazy bytestring before removing the file.