intercalate-related cleanup #468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bodigrim
reviewed
Jan 18, 2022
sjakobi
approved these changes
Jan 19, 2022
Bodigrim
pushed a commit
to Bodigrim/bytestring
that referenced
this pull request
Jan 30, 2022
* Clean up intercalate-related INLINE pragmas * Revert subtle increase in intercalate's strictness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #459 merged, the size-related arithmetic in
intercalatenow needs its own overflow-detection separate from that inconcat, and the INLINE phase markers related to the removedintercalateWithByterule are no longer necessary.