Use primops for unaligned writes when possible #645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Since it looks like |
Bodigrim
approved these changes
Jan 30, 2024
clyring
added a commit
that referenced
this pull request
Feb 5, 2024
* Use primops for unaligned writes when possible * Check MIN_VERSION_base instead of __GLASGOW_HASKELL__ (cherry picked from commit 44375fa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm in no rush to land this. The "right" CPP condition won't work until upstream bumps their version numbers and anyway it might be nice to let the other implementations from #587 get tested more widely in 9.10.1-alpha1 first.