Better get directory contents

[snoyberg]

Implements a fix for the stack overflow described in:

https://ghc.haskell.org/trac/ghc/ticket/9266

[snoyberg]

@hvr Looks like the 7.4 builds are failing for other reasons, and therefore shouldn't prevent this being merged. Are you opposed to me removing 7.4 from the Travis config so we stop getting false negatives?

[hvr]

Well, you'd also have to update the lower bound on base in the cabal file... obviously :-)

However, I haven't looked at the code, but would it be difficult to simply disambiguate the catch-use to retain base-4.5-compat?

System/Directory.hs:402:28:
  Ambiguous occurrence `catch'
  It could refer to either `System.IO.Error.catch',
  imported from `System.IO.Error' at System/Directory.hs:83:1-22
  or `E.catch',
  imported from `Control.Exception.Base' at System/Directory.hs:85:1-34

[snoyberg]

I tried fixing that already and it just reveals another problem. I'll push
that change so there's a clear record of that problem.

On Tue, Feb 17, 2015, 2:22 PM Herbert Valerio Riedel <
[email protected]> wrote:

Well, you'd also have to update the lower bound on base in the cabal
file... obviously :-)

However, I haven't looked at the code, but would it be difficult to simply
disambiguate the catch-use to retain base-4.5-compat?

System/Directory.hs:402:28:
Ambiguous occurrence catch' It could refer to eitherSystem.IO.Error.catch',
imported from System.IO.Error' at System/Directory.hs:83:1-22 orE.catch',
imported from `Control.Exception.Base' at System/Directory.hs:85:1-34

—
Reply to this email directly or view it on GitHub
#17 (comment).

[snoyberg]

Never mind, it was a bug with the Gold linker, which I worked around for testing. This looks good to merge actually.

[hvr]

well... you should be able to merge it yourself :-)

[snoyberg]

Hurrah. I'll move forward on master. Who should be in charge of releasing changes to Hackage?

[hvr]

...whoever takes responsibility for that particular release... :-)

For directory specifically, we should ideally try to make sure we've got everything in we want for GHC 7.10.1 (as ghc bundles a directory release). Otoh, it's no big deal either if we happen to have directory releases inbetween not bundled with GHC; it'll just give the cabal solver a bit more data to work with (and allow GHC 7.8.4 users to access new functionality early if they choose to) :-)

[snoyberg]

If you don't mind, I think I'll leave the release to your discretion then, you certainly have more experience than I do timing releases with GHC.