Skip to content

Improved hPutStr lazy for small chunk sizes #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BebeSparkelSparkel wants to merge 5 commits into from
Closed

Improved hPutStr lazy for small chunk sizes #592

BebeSparkelSparkel wants to merge 5 commits into from

Conversation

@BebeSparkelSparkel
Copy link
Contributor

@BebeSparkelSparkel BebeSparkelSparkel commented May 1, 2024

No description provided.

@BebeSparkelSparkel
Optimized hPutStr for LazyText
5310df8
@BebeSparkelSparkel
Now lazy bytestrings better utilize buffers but takes a performance h…
754f823 
…it at length > 1000

unsure why need to profile to see why for <= 1000 charaters the performace increases by 20% but >= 10,000 the performance is terrible.
@BebeSparkelSparkel
fixed not resetting outer to 0 index
1a78d27
@BebeSparkelSparkel
reduced post commit checks
f50ebc2
@BebeSparkelSparkel
clean up
a1d55cd
@Lysxia
Copy link
Contributor

Lysxia commented May 27, 2024 •
edited
Loading

I think a simpler way is to decompose Text.hPutStr into \h -> Stream.hPutStr h . Text.stream (for some Stream.hPutStr :: Handle -> Stream Char -> IO ()) so you get Lazy.hPutStr h = Stream.hPutStr h . Lazy.stream.

@BebeSparkelSparkel
Copy link
Contributor Author

BebeSparkelSparkel commented May 29, 2024

Thanks I was not aware of lazy stream.

@Lysxia Lysxia mentioned this pull request May 29, 2024
Merged
@Lysxia
Copy link
Contributor

Lysxia commented May 29, 2024

While fixing #442 I ended up doing what I suggested here, in #600.

@Lysxia Lysxia closed this May 29, 2024
@Lysxia Lysxia mentioned this pull request Jun 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BebeSparkelSparkel @Lysxia