Do not silently fail on gzip unzipping

hazelzhao · Mar 7, 2017 · b174744 · b174744
1 parent 11cdf58
commit b174744
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/scrapy/downloadermiddlewares/httpcompression.py b/scrapy/downloadermiddlewares/httpcompression.py
@@ -1,6 +1,6 @@
 import zlib
 
-from scrapy.utils.gz import gunzip, is_gzipped
+from scrapy.utils.gz import gunzip
 from scrapy.http import Response, TextResponse
 from scrapy.responsetypes import responsetypes
 from scrapy.exceptions import NotConfigured

diff --git a/scrapy/spiders/sitemap.py b/scrapy/spiders/sitemap.py
@@ -61,10 +61,7 @@ def _get_sitemap_body(self, response):
         if isinstance(response, XmlResponse):
             return response.body
         elif gzip_magic_number(response):
-            try:
-                return gunzip(response.body)
-            except:
-                pass
+            return gunzip(response.body)
         # actual gzipped sitemap files are decompressed above ;
         # if we are here (response body is not gzipped)
         # and have a response for .xml.gz,