Hide collection on list if no routes in collection #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tried it. Would you like to add an image to instruct user how to add route to collection? Otherwise, it will be a blank page for new users, and they likely have no idea what's going on |
|
I think that make sense. For consistency sake all other tabs including "常用" or "Home" should show the same image when having no data? Maybe similar to the one in "車站" ? |
|
Yes, go ahead. Suggested to prepare 4 images, each for one combination of language and color theme. |
|
Sure. Will see what i can do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently collections are shown under the collections tab even if no routes are in the collection, making it looks like an layout bug. This commit hide the entire collection if there are no routes in that collection.
