Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open team sheets toggled on doesn't augment battle object automatically #609

Open
cameronangliss opened this issue Sep 30, 2024 · 3 comments · May be fixed by #660
Open

Open team sheets toggled on doesn't augment battle object automatically #609

cameronangliss opened this issue Sep 30, 2024 · 3 comments · May be fixed by #660

Comments

@cameronangliss
Copy link
Contributor

cameronangliss commented Sep 30, 2024

This would be a really useful feature. If open team sheets is toggled on, the extra information that is given to the player about the opponent's team should populate the battle object without me having to do anything. I tested, and currently it seems that this doesn't happen yet. Is anybody working on something like this now? @caymansimpson I know you're working on doubles right now and I saw you put in the feature for open team sheets initially, so I'm curious what your thoughts are on this :)

@caymansimpson
Copy link
Contributor

caymansimpson commented Sep 30, 2024

Im not working on this, and I think this would be a great addition! These are the current items that I'm planning on submitting in the next couple of weeks: caymansimpson/EliteFurretAI#42 (comment)

There are also further enhancements on loading information teampreview that I think would be really helpful too (primarily, pulling in stats from your Teambuilder into the pokemon object stored in battle.team, since requests don't give HP stats, which makes damage calcs hard. These are stored in teampreview mons, but not team's mons)

@cameronangliss
Copy link
Contributor Author

Thanks for your quick response! I agree that pulling in information from the Teambuilder would be useful as well, but I think as a first step it would be good to at least have open team sheets populate the battle object (since this is the sensible default anyways). I'll see what I can do!

@cameronangliss
Copy link
Contributor Author

@hsahovic @caymansimpson I've actually been sitting on a solution for this for a little while now, but it isn't fully generalized out to the point that it's good to merge into poke-env or anything. The branch containing this solution comes off of the branch of #569, so I want to wait for that to merge before thinking about how to get these changes in, but they're definitely really worthwhile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants