Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add HIP support #280

Closed
wants to merge 2 commits into from
Closed

feat: add HIP support #280

wants to merge 2 commits into from

Conversation

Disty0
Copy link
Contributor

@Disty0 Disty0 commented Aug 13, 2024

What does this PR do?

Fixes # (issue)

GEMM and GEMV kernels can't be compiled for AMD HIP. This PR adds a check for HIP and uses unpack kernel for HIP.

Before submitting

  • [*] Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you run all tests locally and make sure they pass.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Disty0 Disty0 requested a review from dacorvo as a code owner August 13, 2024 20:28
@dacorvo
Copy link
Collaborator

dacorvo commented Aug 14, 2024

Thank you for this pull-request. This looks good to me, but can you just:

  • rebase your branch,
  • amend you commit message to use the conventional commit convention: something like "feat: add HIP support"

@dacorvo
Copy link
Collaborator

dacorvo commented Aug 14, 2024

FYI, if you commit is not conventional, the CI will not run any tests.

@Disty0 Disty0 changed the title AMD HIP support feat: add HIP support Aug 14, 2024
@Disty0
Copy link
Contributor Author

Disty0 commented Aug 14, 2024

Done.

Copy link

This PR is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Aug 31, 2024
Copy link

github-actions bot commented Sep 5, 2024

This PR was closed because it has been stalled for 5 days with no activity.

Copy link

github-actions bot commented Oct 3, 2024

This PR is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Oct 3, 2024
@dacorvo dacorvo mentioned this pull request Oct 4, 2024
@dacorvo
Copy link
Collaborator

dacorvo commented Oct 4, 2024

Rebased in #330

@dacorvo dacorvo closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants