feat(tonic-xds): A27 bootstrap config from env var#2535
Open
YutaoMa wants to merge 2 commits intohyperium:masterfrom
Open
feat(tonic-xds): A27 bootstrap config from env var#2535YutaoMa wants to merge 2 commits intohyperium:masterfrom
YutaoMa wants to merge 2 commits intohyperium:masterfrom
Conversation
a1214ab to
37735c0
Compare
gu0keno0
approved these changes
Mar 6, 2026
Collaborator
gu0keno0
left a comment
There was a problem hiding this comment.
I tend to think we should still support directly passing bootstrap configs as structs.
In many cases, either file or env var is cumbersome to use
gu0keno0
reviewed
Mar 6, 2026
39b5790 to
9135880
Compare
ankurmittal
reviewed
Mar 13, 2026
| } | ||
|
|
||
| /// Convert the bootstrap node config to an `xds_client::Node`. | ||
| pub(crate) fn to_node(&self) -> Node { |
Collaborator
There was a problem hiding this comment.
in rust to_node will mean that you are consuming self, maybe we should consume self and let the caller clone if they want to keep config around
Also better to implement From trait
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Ref: #2444
gRFC A27 specifies how gRPC clients can use
GRPC_XDS_BOOTSTRAPto bootstrap xDS (reference). There is alsoGRPC_XDS_BOOTSTRAP_CONFIGfor inline config (reference). This PR wires in both.Solution
For now because we haven't added xDS client building logic in
tonic-xdsyet, this PR stores the parsed and validated config into the newly introducedBootstrapConfigstruct. Subsequent PRs will implement the logic to feed this config into xDS client builder.