-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
caliper-ethereum : Add new tests for connectorFactory
and ethereum-connector
#1560
Open
Sweetdevil144
wants to merge
18
commits into
hyperledger-caliper:main
Choose a base branch
from
Sweetdevil144:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
b581ee8
Add tests for caliper-ethereum package
Sweetdevil144 d40236f
Update test files for ethereum-connector.js
Sweetdevil144 9e010f6
Update test cases for ethereum-connector.js
Sweetdevil144 e8e1151
Merge branch 'hyperledger:main' into main
Sweetdevil144 4d3ff42
Update connectorFactory test utils
Sweetdevil144 7912cf4
chore: Update connectorFactory test utils
Sweetdevil144 7ae2f49
Test Invalid network connections for connectorFactory.js
Sweetdevil144 52f90b3
Update EthereumConnector.js suites
Sweetdevil144 3019394
Update ethereumConenctor.js
Sweetdevil144 66d930f
Merge branch 'hyperledger:main' into main
Sweetdevil144 3209b25
Merge branch 'hyperledger:main' into main
Sweetdevil144 63c45ff
Update sample-configs
Sweetdevil144 7929e14
Update checkConfig() tests
Sweetdevil144 40a06d4
Update 'describe' messages and remove empty test suites
Sweetdevil144 3d27fae
Facing Package Issues while Running test suites
Sweetdevil144 b2f4ae1
Updated test suites for caliper-ethereun package
Sweetdevil144 ffdb9f8
Merge branch 'hyperledger:main' into main
Sweetdevil144 c8f2a2e
Merge branch 'hyperledger:main' into main
Sweetdevil144 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update 'describe' messages and remove empty test suites
Signed-off-by: Abhinav Pandey <[email protected]>
- Loading branch information
commit 40a06d40a21b478136134ae5a25017c3419ffd78
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test should be part of the connector factory. As stated before we don't want to have tests that directly test the constructor of the EthereumConnector as it isn't really a public constructor. Please move this test to the ConnectorFactory tests.