Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this PR fixes #820 (Credential and Presentation attributes mime-type adjustments) #831

Closed
wants to merge 4 commits into from

Conversation

SumantxD
Copy link

@SumantxD SumantxD commented May 7, 2023

as instructed AttrValue enum was created with two variants Plain and Encoded, the plain having { value: String } and Encoded with { value: String, mime_type: MaybeKnown }, which will facilitate in easy deserialization,

the AttrValue has been used in both the attributes (CredentialAttr and PresentationAttr), and the unit tests have been adjusted accordingly,

hope that this PR will solves the issue, any changes or feedback is welcomed

Thank You,

Copy link
Contributor

@bobozaur bobozaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite there yet, but not far off either. With some tweaking this will look like what we need. Good job so far!

messages/src/msg_fields/protocols/cred_issuance/mod.rs Outdated Show resolved Hide resolved
messages/src/msg_fields/protocols/present_proof/propose.rs Outdated Show resolved Hide resolved
@bobozaur bobozaur linked an issue May 8, 2023 that may be closed by this pull request
Signed-off-by: SumantxD <[email protected]>
@SumantxD SumantxD closed this May 9, 2023
@SumantxD SumantxD deleted the fix-820 branch May 9, 2023 07:06
@SumantxD SumantxD restored the fix-820 branch May 9, 2023 07:07
@SumantxD SumantxD reopened this May 9, 2023
@SumantxD
Copy link
Author

SumantxD commented May 9, 2023

added the required modifications

Copy link
Contributor

@bobozaur bobozaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'd love to see the modules separated in different files for readability.

messages/src/msg_fields/mod.rs Outdated Show resolved Hide resolved
@SumantxD
Copy link
Author

SumantxD commented May 9, 2023

added those changes

@bobozaur
Copy link
Contributor

bobozaur commented May 9, 2023

added those changes

@SumantxD What I meant was for each of those to be individual modules, so the directory structure would look more like this:

  • msg_fields
    • common
      • attr_value.rs
      • mod.rs
    • protocols
    • mod.rs

Could you please adjust the files to match that structure?

@SumantxD
Copy link
Author

SumantxD commented May 9, 2023

@bobozaur I have fixed the directory structure

@bobozaur
Copy link
Contributor

bobozaur commented May 9, 2023

@bobozaur I have fixed the directory structure

Nice. Good job!

I triggered the CI run, let's wait on that and if it's all good I'll loop in other maintainers for a quick review and then we can merge this.

@SumantxD
Copy link
Author

@bobozaur a lot of checks were unsuccessful in the CI run, will it create problems? if so how can i fix it?

@bobozaur
Copy link
Contributor

@bobozaur a lot of checks were unsuccessful in the CI run, will it create problems? if so how can i fix it?

It will, yes. The checks are there to ensure the code works as expected (building, testing, etc.).

You can explore the CI jobs and check the errors, as well as testing locally (the best way to figure out what the CI runs is to look in the main.yaml file and maybe search for things such as cargo test).

After you fix the tests et al we can trigger another CI run and see how it behaves.

@Patrik-Stas
Copy link
Contributor

Closing per inactivity. Feel free to reopen if you would like to continue in this work.

@Patrik-Stas Patrik-Stas closed this Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Credential and Presentation attributes mime-type adjustments
3 participants