-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
this PR fixes #820 (Credential and Presentation attributes mime-type adjustments) #831
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not quite there yet, but not far off either. With some tweaking this will look like what we need. Good job so far!
Signed-off-by: SumantxD <[email protected]>
added the required modifications |
Signed-off-by: SumantxD <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I'd love to see the modules separated in different files for readability.
added those changes |
Signed-off-by: SumantxD <[email protected]>
Signed-off-by: SumantxD <[email protected]>
@SumantxD What I meant was for each of those to be individual modules, so the directory structure would look more like this:
Could you please adjust the files to match that structure? |
@bobozaur I have fixed the directory structure |
Nice. Good job! I triggered the CI run, let's wait on that and if it's all good I'll loop in other maintainers for a quick review and then we can merge this. |
@bobozaur a lot of checks were unsuccessful in the CI run, will it create problems? if so how can i fix it? |
It will, yes. The checks are there to ensure the code works as expected (building, testing, etc.). You can explore the CI jobs and check the errors, as well as testing locally (the best way to figure out what the CI runs is to look in the After you fix the tests et al we can trigger another CI run and see how it behaves. |
Closing per inactivity. Feel free to reopen if you would like to continue in this work. |
as instructed AttrValue enum was created with two variants Plain and Encoded, the plain having { value: String } and Encoded with { value: String, mime_type: MaybeKnown }, which will facilitate in easy deserialization,
the AttrValue has been used in both the attributes (CredentialAttr and PresentationAttr), and the unit tests have been adjusted accordingly,
hope that this PR will solves the issue, any changes or feedback is welcomed
Thank You,