Store all token transfer inputs on operation #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the transfer is only recorded upon success, all inputs must be stored on the operation in order to support retries or accurately report failures. Signed-off-by: Andrew Richardson <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #478 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 266 266
Lines 15134 15142 +8
=======================================
+ Hits 15123 15131 +8
Misses 11 11
Continue to review full report at Codecov.
|
Signed-off-by: Andrew Richardson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the transfer is only recorded upon success, all inputs must be stored
on the operation in order to support retries or accurately report failures.
Needed for #400 and #316