Skip to content

fix: Rewrite CSS style attributes in SVG#10584

Merged
jennifer-richards merged 1 commit intoietf-tools:mainfrom
martinthomson:rewrite-css-style-attr
Mar 23, 2026
Merged

fix: Rewrite CSS style attributes in SVG#10584
jennifer-richards merged 1 commit intoietf-tools:mainfrom
martinthomson:rewrite-css-style-attr

Conversation

@martinthomson
Copy link
Copy Markdown
Contributor

This makes the dark mode work properly for drafts like https://datatracker.ietf.org/doc/html/draft-hajdusek-qirg-timing-physics-01 which have diagrams that use a mix of ordinary attributes and the style attribute. Using the style attribute makes the rules there invisible to the method we use for the remapping of black and white for dark mode.

This makes the dark mode work properly for drafts like
https://datatracker.ietf.org/doc/html/draft-hajdusek-qirg-timing-physics-01
which have diagrams that use a mix of ordinary attributes and the style
attribute.  Using the style attribute makes the rules there invisible to
the method we use for the remapping of black and white for dark mode.
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.36%. Comparing base (76fd25a) to head (989ce2a).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10584   +/-   ##
=======================================
  Coverage   88.36%   88.36%           
=======================================
  Files         327      327           
  Lines       44092    44092           
=======================================
  Hits        38964    38964           
  Misses       5128     5128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jennifer-richards jennifer-richards merged commit eb041f7 into ietf-tools:main Mar 23, 2026
15 of 16 checks passed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants