Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dvt select type design #52

Merged
merged 7 commits into from
Dec 5, 2023
Merged

fix: dvt select type design #52

merged 7 commits into from
Dec 5, 2023

Conversation

Muhammed-baban
Copy link

SUMMARY

fix: dvt select type design

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@Muhammed-baban Muhammed-baban self-assigned this Dec 5, 2023
? theme.colors.dvt.primary.light2
: theme.colors.dvt.grayscale.light2};
border: none;
appearance: none;
margin-bottom: 3px;
margin-bottom: ${({ typeDesign }) =>
typeDesign === 'form' ? '12px' : '3px'};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StyledSelect içinde margin-bottom kaldırmalı. Gerisi divler gap gibi olacak

@omerfbolat omerfbolat merged commit 0b9011a into dev Dec 5, 2023
46 of 47 checks passed
@omerfbolat omerfbolat deleted the fix/dvt-select-type-design branch December 5, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants