Skip to content

Fix endpoint for exporting games of user#57

Merged
ion232 merged 2 commits intomainfrom
ion232/fix-game-json-object
Aug 26, 2024
Merged

Fix endpoint for exporting games of user#57
ion232 merged 2 commits intomainfrom
ion232/fix-game-json-object

Conversation

@ion232
Copy link
Owner

@ion232 ion232 commented Aug 26, 2024

No description provided.

ion232 added 2 commits August 26, 2024 21:53
Merge request #41 changed GameJson - now causing exports to fail.
Originally ChallengeAI used GameJson and it was modified accordingly.
This was incorrect however, and I changed ChallengeAI to use Move.
However I failed to revert the changes to GameJson.
This wasn't seen because GameJson isn't used in many places.

In addition, I've remove any null title from the test files.
I'm assuming this was a bug in an older version of lila.
The newer game_json example omits title if null, as it's supposed to.
Therefore I'm assuming this is the expected behaviour.
@ion232 ion232 force-pushed the ion232/fix-game-json-object branch from f86b16c to c7a4c70 Compare August 26, 2024 20:55
@ion232 ion232 changed the title Fix endpoint for exporting games for user Fix endpoint for exporting games of user Aug 26, 2024
@ion232 ion232 merged commit abe364f into main Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant