Skip to content

fix(overlays): ensure that only topmost overlay is announced by screen readers #28997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
averyjohnston merged 18 commits into from
Feb 9, 2024
Merged

fix(overlays): ensure that only topmost overlay is announced by screen readers #28997

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
36f8cd4
fix(overlays): ensure that only topmost overlay is visible to screen …
Feb 7, 2024
8bcc554
lint
Feb 7, 2024
2224c3c
revert markup changes in test file
Feb 7, 2024
46b6a31
lint
Feb 7, 2024
e19913e
Merge remote-tracking branch 'origin/main' into FW-4929
Feb 7, 2024
e17e318
try downgrading Stencil to see if spec test still fails
Feb 7, 2024
ca78b7b
Revert "try downgrading Stencil to see if spec test still fails"
Feb 7, 2024
4f85596
try clearing toast timeout on disconnect to fix spec tests
Feb 7, 2024
41594cc
try removing timeout from CSS animations fallback to fix spec tests
Feb 8, 2024
78f6913
Revert "try removing timeout from CSS animations fallback to fix spec…
Feb 8, 2024
4717f2f
Revert "try clearing toast timeout on disconnect to fix spec tests"
Feb 8, 2024
658e0d7
try splitting tests into separate file
Feb 8, 2024
900ec0f
add comment
Feb 8, 2024
938d964
try wrapping both describe blocks in a single parent one
Feb 8, 2024
871b363
remove empty test file
Feb 8, 2024
2e3bf2a
remove describe wrapper (should trigger spec test issue again)
Feb 8, 2024
5d08341
reset config in toast tests
Feb 8, 2024
6599390
Merge remote-tracking branch 'origin/main' into FW-4929
Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint
  • Loading branch information
amandaesmith3 committed Feb 7, 2024
commit 46b6a31a899b03c7755ef48e085dca2b048adfd1
4 changes: 1 addition & 3 deletions core/src/utils/test/overlays/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,7 @@
<ion-button id="create" onclick="createModal()">Create a Modal</ion-button>
<ion-button id="create-nested" onclick="createNestedOverlayModal()">Create Nested Overlay Modal</ion-button>
<ion-button id="present" onclick="presentHiddenModal()">Present a Hidden Modal</ion-button>
<ion-button id="create-and-present" onclick="createAndPresentModal()"
>Create and Present a Modal</ion-button
>
<ion-button id="create-and-present" onclick="createAndPresentModal()">Create and Present a Modal</ion-button>
<ion-button id="simulate" onclick="backButton()">Simulate Hardware Back Button</ion-button>
<ion-button id="create-and-present-toast" onclick="createAndPresentToast()"
>Create and Present Toast</ion-button
Expand Down