Skip to content

Conversation

@gumb0
Copy link
Member

@gumb0 gumb0 commented Feb 24, 2025

Implement ethereum/EIPs#9298

@gumb0 gumb0 self-assigned this Feb 24, 2025
@gumb0 gumb0 force-pushed the eof/compute-eofcreate-address branch 2 times, most recently from bcacbde to 68a8ff7 Compare February 24, 2025 11:54
@codecov
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.47%. Comparing base (462964c) to head (8958936).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1140      +/-   ##
==========================================
- Coverage   94.48%   94.47%   -0.01%     
==========================================
  Files         170      170              
  Lines       18020    18024       +4     
==========================================
+ Hits        17027    17029       +2     
- Misses        993      995       +2     
Flag Coverage Δ
eof_execution_spec_tests 20.60% <0.00%> (-0.34%) ⬇️
ethereum_tests 27.04% <0.00%> (-0.01%) ⬇️
ethereum_tests_silkpre 19.50% <0.00%> (-0.01%) ⬇️
execution_spec_tests 21.29% <0.00%> (-0.01%) ⬇️
unittests 91.79% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
lib/evmone/instructions_calls.cpp 98.29% <ø> (-0.87%) ⬇️
test/state/host.cpp 100.00% <100.00%> (ø)
test/state/host.hpp 100.00% <ø> (ø)
test/unittests/eof_example_test.cpp 100.00% <100.00%> (ø)
...est/unittests/state_transition_eof_create_test.cpp 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gumb0 gumb0 force-pushed the eof/compute-eofcreate-address branch from 68a8ff7 to be436a5 Compare February 25, 2025 17:51
Copy link
Member

@pdobacz pdobacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should also remove hashing cost from lib/evmone/instructions_calls.cpp:408

@gumb0 gumb0 force-pushed the eof/compute-eofcreate-address branch from be436a5 to 1056b16 Compare February 26, 2025 10:22
@gumb0 gumb0 requested review from chfast and pdobacz March 14, 2025 16:05
@gumb0 gumb0 force-pushed the eof/compute-eofcreate-address branch 2 times, most recently from fbe305e to 5a49ebe Compare March 20, 2025 18:27
@gumb0 gumb0 force-pushed the eof/compute-eofcreate-address branch from 5a49ebe to 13dfa85 Compare April 7, 2025 16:10
@gumb0 gumb0 force-pushed the eof/compute-eofcreate-address branch from 4e44584 to 8958936 Compare April 7, 2025 16:21
@gumb0 gumb0 marked this pull request as ready for review April 7, 2025 16:28
@gumb0 gumb0 merged commit 0ca0ced into master Apr 7, 2025
25 checks passed
@gumb0 gumb0 deleted the eof/compute-eofcreate-address branch April 7, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants