-
Notifications
You must be signed in to change notification settings - Fork 333
EOF: Make container sections size 4 bytes #1171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1171 +/- ##
==========================================
+ Coverage 94.90% 94.91% +0.01%
==========================================
Files 171 171
Lines 19648 19675 +27
==========================================
+ Hits 18646 18675 +29
+ Misses 1002 1000 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
411b724 to
e86a71e
Compare
258362e to
51d79f7
Compare
af0438d to
18b4ef7
Compare
8119770 to
07618f7
Compare
| uint32_t data_offset = 0; | ||
| /// Size of every container section. | ||
| std::vector<uint16_t> container_sizes; | ||
| std::vector<uint32_t> container_sizes; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strictly speaking we don't need the changes here yet, given current code size limit.
But during header validation we do need to parse full 4-byte sizes and then use them to compare declared body size against actual body size, so we have there a vector of uint32_t container sizes already, and it's simpler and more efficient to just move it into this vector here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We actually should not copy the sizes to the separate vector but read these on demand. But this change is for some other time.
cdf8231 to
11e67df
Compare
c00e765 to
eb4a6c2
Compare
eb4a6c2 to
9416f60
Compare
| uint32_t data_offset = 0; | ||
| /// Size of every container section. | ||
| std::vector<uint16_t> container_sizes; | ||
| std::vector<uint32_t> container_sizes; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We actually should not copy the sizes to the separate vector but read these on demand. But this change is for some other time.
d6b848e to
9027d1b
Compare
f542604 to
1fc023b
Compare
1fc023b to
d4ce111
Compare
No description provided.