Skip to content

Conversation

@gumb0
Copy link
Member

@gumb0 gumb0 commented Mar 17, 2025

No description provided.

@codecov
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 98.01980% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.91%. Comparing base (dab408f) to head (d4ce111).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
lib/evmone/eof.cpp 98.38% 1 Missing ⚠️
test/unittests/eof_test.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1171      +/-   ##
==========================================
+ Coverage   94.90%   94.91%   +0.01%     
==========================================
  Files         171      171              
  Lines       19648    19675      +27     
==========================================
+ Hits        18646    18675      +29     
+ Misses       1002     1000       -2     
Flag Coverage Δ
eof_execution_spec_tests 2.53% <0.00%> (?)
ethereum_tests 22.36% <0.00%> (-0.03%) ⬇️
ethereum_tests_silkpre 17.87% <0.00%> (-0.03%) ⬇️
execution_spec_tests 19.56% <0.00%> (-0.03%) ⬇️
unittests 92.46% <99.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
lib/evmone/eof.hpp 100.00% <100.00%> (ø)
test/state/host.cpp 100.00% <100.00%> (ø)
test/unittests/eof_example_test.cpp 100.00% <100.00%> (ø)
test/unittests/eof_validation_test.cpp 99.41% <100.00%> (+<0.01%) ⬆️
...est/unittests/state_transition_eof_create_test.cpp 100.00% <100.00%> (ø)
test/unittests/state_transition_txcreate_test.cpp 100.00% <100.00%> (ø)
test/utils/bytecode.hpp 97.41% <100.00%> (+0.02%) ⬆️
lib/evmone/eof.cpp 86.19% <98.38%> (+0.26%) ⬆️
test/unittests/eof_test.cpp 94.54% <50.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gumb0 gumb0 force-pushed the eof/container-size-4bytes branch 2 times, most recently from 411b724 to e86a71e Compare March 18, 2025 13:53
@gumb0 gumb0 force-pushed the eof/container-size-4bytes branch 3 times, most recently from 258362e to 51d79f7 Compare March 20, 2025 11:19
@gumb0 gumb0 changed the base branch from master to data-0xff March 20, 2025 11:23
@gumb0 gumb0 force-pushed the eof/container-size-4bytes branch 7 times, most recently from af0438d to 18b4ef7 Compare March 20, 2025 13:18
@gumb0 gumb0 force-pushed the eof/container-size-4bytes branch 3 times, most recently from 8119770 to 07618f7 Compare March 20, 2025 15:18
uint32_t data_offset = 0;
/// Size of every container section.
std::vector<uint16_t> container_sizes;
std::vector<uint32_t> container_sizes;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking we don't need the changes here yet, given current code size limit.

But during header validation we do need to parse full 4-byte sizes and then use them to compare declared body size against actual body size, so we have there a vector of uint32_t container sizes already, and it's simpler and more efficient to just move it into this vector here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually should not copy the sizes to the separate vector but read these on demand. But this change is for some other time.

@gumb0 gumb0 force-pushed the eof/container-size-4bytes branch 3 times, most recently from cdf8231 to 11e67df Compare March 31, 2025 10:18
@gumb0 gumb0 requested review from chfast and pdobacz March 31, 2025 10:41
@gumb0 gumb0 force-pushed the eof/container-size-4bytes branch from c00e765 to eb4a6c2 Compare March 31, 2025 15:25
@gumb0 gumb0 force-pushed the eof/container-size-4bytes branch from eb4a6c2 to 9416f60 Compare April 8, 2025 13:52
uint32_t data_offset = 0;
/// Size of every container section.
std::vector<uint16_t> container_sizes;
std::vector<uint32_t> container_sizes;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually should not copy the sizes to the separate vector but read these on demand. But this change is for some other time.

Base automatically changed from data-0xff to master April 9, 2025 12:42
@gumb0 gumb0 force-pushed the eof/container-size-4bytes branch from d6b848e to 9027d1b Compare April 9, 2025 15:34
@gumb0 gumb0 marked this pull request as ready for review April 9, 2025 15:35
@gumb0 gumb0 force-pushed the eof/container-size-4bytes branch 5 times, most recently from f542604 to 1fc023b Compare April 9, 2025 16:30
@chfast chfast added the EOF label Apr 9, 2025
@chfast chfast changed the title Make container sections size 4 bytes EOF: Make container sections size 4 bytes Apr 9, 2025
@gumb0 gumb0 force-pushed the eof/container-size-4bytes branch from 1fc023b to d4ce111 Compare April 9, 2025 16:38
@gumb0 gumb0 enabled auto-merge April 9, 2025 16:44
@gumb0 gumb0 merged commit 7afc51c into master Apr 9, 2025
23 checks passed
@gumb0 gumb0 deleted the eof/container-size-4bytes branch April 9, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants