EOF: Add rlp_encode of InitcodeTransaction #1192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
reviewed
Apr 11, 2025
| tx.to.has_value() ? tx.to.value() : bytes_view(), tx.value, tx.data, | ||
| tx.access_list, tx.authorization_list, tx.v, tx.r, tx.s); | ||
| } | ||
| else // Transaction::Type::initcodes |
Member
There was a problem hiding this comment.
This is kinda weird pattern that for any new tx type we need to convert a comment to if. Maybe change it to proper else if and return something dummy for the default path (can be also unreachable()).
chfast
approved these changes
Apr 11, 2025
| tx.to.has_value() ? tx.to.value() : bytes_view(), tx.value, tx.data, | ||
| tx.access_list, tx.authorization_list, tx.v, tx.r, tx.s); | ||
| } | ||
| else // Transaction::Type::initcodes |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1192 +/- ##
==========================================
- Coverage 94.91% 94.89% -0.03%
==========================================
Files 171 171
Lines 19675 19681 +6
==========================================
+ Hits 18675 18676 +1
- Misses 1000 1005 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
Author
|
We need to release and update EEST to tickle the rlp encoding lines for the new tx type. Making a self not to double check that is the case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.