precompiles: Refactor modexp gas calculation #1245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the modexp gas calculation to address issue #1242 by updating lambda functions and parameter extraction for improved consistency and clarity.
- Updated lambda parameters from ambiguous names (y) to descriptive ones (max_len)
- Refactored the selection of gas calculation parameters using a lambda that returns a Params struct
- Streamlined calculation logic in both calc_mult_complexity functions
Comments suppressed due to low confidence (1)
test/state/precompiles.cpp:142
- [nitpick] Consider renaming the lambda used for parameter selection to a descriptive name (e.g., 'get_params') to improve readability.
const auto& [min_gas, final_divisor, calc_mult_complexity] = [rev]() noexcept -> Params {
rodiazet
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor modexp gas calculation to help with #1242.