Use alignas to specify EVM stack space alignment #1304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1304 +/- ##
==========================================
- Coverage 87.15% 87.15% -0.01%
==========================================
Files 167 167
Lines 24744 24732 -12
Branches 4059 4059
==========================================
- Hits 21566 21554 -12
Misses 537 537
Partials 2641 2641
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
7b04da8 to
bb5db7d
Compare
Use additional wrapping type `StackSpace::Storage` with `alignas(32) instead of `std::aligned_alloc` to specify the EVM stack space alignment in portable way.
bb5db7d to
6e08832
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use additional wrapping type
StackSpace::Storagewithalignas(32)instead ofstd::aligned_allocto specify the EVM stack space alignment in portable way.