crypto: Switch to Jacobian coordinates in ECC #1312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
commented
Sep 11, 2025
lib/evmone_precompiles/ecc.hpp
Outdated
| const auto s2 = y2 * z1z1z1; | ||
| const auto h = u2 - u1; | ||
| const auto r = s2 - s1; | ||
| assert(r != 0); // TODO: Untested. |
Member
Author
There was a problem hiding this comment.
This is actually impossible. I will have a follow up PR which detects equal points in more efficient way.
Member
Author
|
Benchmarks: |
rodiazet
approved these changes
Sep 11, 2025
lib/evmone_precompiles/ecc.hpp
Outdated
| z3 = z3 + t0; | ||
| const auto z1z1 = z1 * z1; | ||
| const auto u2 = x2 * z1z1; | ||
| const auto t0 = z1 * z1z1; |
Member
Author
There was a problem hiding this comment.
I translated this "script": https://www.hyperelliptic.org/EFD/g1p/auto-code/shortw/jacobian/addition/madd.op3. But I'll change it.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1312 +/- ##
==========================================
- Coverage 87.15% 87.13% -0.02%
==========================================
Files 167 167
Lines 24761 24740 -21
Branches 4058 4064 +6
==========================================
- Hits 21581 21558 -23
- Misses 537 538 +1
- Partials 2643 2644 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Replace using of projective coordinates for elliptic curve point to Jacobian coordinates. Jacobian formulas are faster, easier to use and some of the furmulas are independent of the a parameter of a curve (should be handy for implementing secp256r1).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace using of projective coordinates for elliptic curve point to Jacobian coordinates. Jacobian formulas are faster, easier to use and some of the furmulas are independent of the a parameter of a curve (should be handy for implementing secp256r1).