Skip to content

Conversation

@pdobacz
Copy link
Member

@pdobacz pdobacz commented Sep 24, 2025

as title, EIP-7918 formula was incorrectly implemented, should be:

... OB * get_base_fee_per_blob_gas(parent):
...  * (blobSchedule.max - blobSchedule.target) // blobSchedule.max      <==== not target
... 
...  - target_blob_gas

This activates one skipped test

@pdobacz pdobacz requested a review from chfast September 24, 2025 10:40
@codecov
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.21%. Comparing base (bfbd02f) to head (c661316).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1322   +/-   ##
=======================================
  Coverage   87.21%   87.21%           
=======================================
  Files         167      167           
  Lines       24728    24728           
  Branches     4064     4064           
=======================================
  Hits        21566    21566           
  Misses        522      522           
  Partials     2640     2640           
Flag Coverage Δ
eest-develop 23.27% <100.00%> (ø)
eest-develop-gmp 15.90% <0.00%> (ø)
eest-legacy 11.13% <0.00%> (ø)
eest-legacy-silkpre 17.66% <0.00%> (ø)
evmone-unittests 83.75% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
core 93.52% <100.00%> (ø)
tooling 88.35% <ø> (ø)
tests 84.12% <ø> (ø)
Files with missing lines Coverage Δ
test/blockchaintest/blockchaintest_runner.cpp 77.69% <ø> (ø)
test/state/block.cpp 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chfast chfast merged commit 700d55c into master Sep 24, 2025
23 checks passed
@chfast chfast deleted the fix-eip7918 branch September 24, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants