Skip to content

Conversation

@chfast
Copy link
Member

@chfast chfast commented Oct 13, 2025

Add a separate procedure for testing a bit in uint256. It improves readability and performance slightly (up to 1%).

@chfast chfast requested a review from rodiazet October 13, 2025 08:19
@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.25%. Comparing base (92e8882) to head (9720a1d).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1336   +/-   ##
=======================================
  Coverage   87.24%   87.25%           
=======================================
  Files         169      169           
  Lines       24970    24977    +7     
  Branches     4106     4106           
=======================================
+ Hits        21786    21793    +7     
  Misses        529      529           
  Partials     2655     2655           
Flag Coverage Δ
eest-develop 79.89% <100.00%> (+0.01%) ⬆️
eest-develop-gmp 15.96% <0.00%> (-0.01%) ⬇️
eest-legacy 11.21% <0.00%> (-0.01%) ⬇️
eest-legacy-silkpre 17.65% <87.50%> (+0.02%) ⬆️
evmone-unittests 83.82% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
core 93.59% <100.00%> (+<0.01%) ⬆️
tooling 88.08% <ø> (ø)
tests 84.14% <ø> (ø)
Files with missing lines Coverage Δ
lib/evmone_precompiles/ecc.hpp 96.61% <100.00%> (+0.10%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@rodiazet rodiazet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chfast chfast merged commit ae53163 into master Oct 21, 2025
23 checks passed
@chfast chfast deleted the ecc_opt_test_bit branch October 21, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants