Skip to content

Conversation

@pdobacz
Copy link
Member

@pdobacz pdobacz commented Oct 21, 2025

Coverage picks up the line in execution_state.hpp as uncovered, because it is used only in advanced execution. But maybe that can do away with the same method baseline uses?

Treat this more as a question - I'm unsure if these methods are actually fully equivalent. @chfast ?

@pdobacz pdobacz requested a review from chfast October 21, 2025 07:11
@pdobacz
Copy link
Member Author

pdobacz commented Oct 21, 2025

ah, the other way around would also seem to work and make the line covered properly - we can make baseline use the .data method which advanced uses. LMK

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.24%. Comparing base (92e8882) to head (2d56ab0).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1338      +/-   ##
==========================================
- Coverage   87.24%   87.24%   -0.01%     
==========================================
  Files         169      169              
  Lines       24970    24969       -1     
  Branches     4106     4107       +1     
==========================================
- Hits        21786    21785       -1     
  Misses        529      529              
  Partials     2655     2655              
Flag Coverage Δ
eest-develop 79.88% <ø> (+0.01%) ⬆️
eest-develop-gmp 15.97% <0.00%> (+<0.01%) ⬆️
eest-legacy 11.22% <0.00%> (+<0.01%) ⬆️
eest-legacy-silkpre 17.63% <0.00%> (+<0.01%) ⬆️
evmone-unittests 83.81% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
core 93.58% <100.00%> (-0.01%) ⬇️
tooling 88.08% <ø> (ø)
tests 84.14% <100.00%> (ø)
Files with missing lines Coverage Δ
lib/evmone/advanced_execution.cpp 100.00% <100.00%> (ø)
lib/evmone/execution_state.hpp 92.53% <ø> (-0.11%) ⬇️
test/unittests/execution_state_test.cpp 43.68% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pdobacz pdobacz merged commit 22458a0 into master Oct 21, 2025
23 checks passed
@pdobacz pdobacz deleted the exec-state-dead-code branch October 21, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants