Skip to content

Conversation

@chfast
Copy link
Member

@chfast chfast commented Oct 28, 2025

Move the BlobSchedule helpers from the evmone::state library to tests utils because these depend on the test utils already. Otherwise, this breaks linking of the tools which only need the state library without test utils.

@chfast chfast requested a review from pdobacz October 28, 2025 12:23
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.77%. Comparing base (c7f3fd6) to head (ad4ac12).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1349      +/-   ##
==========================================
- Coverage   84.82%   84.77%   -0.05%     
==========================================
  Files         169      169              
  Lines       20373    20373              
  Branches     4125     4125              
==========================================
- Hits        17281    17271      -10     
- Misses        440      445       +5     
- Partials     2652     2657       +5     
Flag Coverage Δ
eest-develop 80.41% <100.00%> (-0.02%) ⬇️
eest-develop-gmp 14.66% <29.41%> (ø)
eest-legacy 10.26% <11.11%> (ø)
eest-legacy-silkpre 16.20% <23.52%> (ø)
evmone-unittests 81.18% <94.44%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
core 92.79% <ø> (+0.02%) ⬆️
tooling 83.76% <100.00%> (-0.63%) ⬇️
tests 81.42% <100.00%> (ø)
Files with missing lines Coverage Δ
test/blockchaintest/blockchaintest_loader.cpp 95.23% <ø> (ø)
test/state/block.cpp 100.00% <ø> (ø)
test/state/block.hpp 100.00% <ø> (ø)
test/state/transaction.hpp 100.00% <ø> (ø)
test/statetest/statetest.hpp 90.90% <ø> (ø)
test/statetest/statetest_loader.cpp 92.67% <100.00%> (ø)
test/statetest/statetest_runner.cpp 71.87% <100.00%> (ø)
test/t8n/t8n.cpp 71.42% <100.00%> (ø)
test/unittests/state_block_test.cpp 27.27% <ø> (ø)
test/unittests/state_transition_block_test.cpp 100.00% <100.00%> (ø)
... and 3 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chfast chfast force-pushed the move_blob_schedule branch from 5f50e07 to efce4de Compare October 28, 2025 12:24
Copy link
Member

@pdobacz pdobacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chfast chfast force-pushed the move_blob_schedule branch 2 times, most recently from 65f82fc to 8f708f1 Compare October 28, 2025 22:14
Move the `BlobSchedule` helpers from the `evmone::state` library to
tests utils because these depend on the test utils already. Otherwise,
this breaks linking of the tools which only need the `state` library
without test utils.
@chfast chfast force-pushed the move_blob_schedule branch from 8f708f1 to ad4ac12 Compare October 28, 2025 22:14
@chfast chfast merged commit 83ffa2b into master Oct 29, 2025
22 of 23 checks passed
@chfast chfast deleted the move_blob_schedule branch October 29, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants