Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup conda environment correctly for ZSH #707

Closed
wants to merge 1 commit into from

Conversation

j3soon
Copy link
Contributor

@j3soon j3soon commented Jul 19, 2024

Description

The source setup_conda_env.sh must be run in the Isaac Sim directory for the script to run correctly when using ZSH.

Fixes #703, #103


This PR also depends on a upstream Isaac Sim issue (internal nvbugs 3752249) to make conda fully usable in ZSH. Meanwhile, we can use a quick patch as described below:

  • Clone and link isaac lab
    git clone [email protected]:isaac-sim/IsaacLab.git
    cd IsaacLab
    ln -s ~/.local/share/ov/pkg/isaac-sim-4.0.0 _isaac_sim
  • Quick patch (not required after resolving internal nvbugs 3752249)
    cd _isaac_sim
    mv setup_python_env.sh setup_python_env.sh.bak
    curl -O https://raw.githubusercontent.com/j3soon/isaac-extended/master/isaac-sim-4.0.0-patch/linux/setup_python_env.sh
    chmod +x setup_python_env.sh
    cd ..
  • Activate without error, install and run example
    ./isaaclab.sh --conda
    conda activate isaaclab
    sudo apt install cmake build-essential
    ./isaaclab.sh --install
    # Run any script, for an example:
    ./isaaclab.sh -p source/standalone/demos/quadrupeds.py

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@j3soon j3soon changed the title Setup conda environment correctly Setup conda environment correctly for ZSH Jul 20, 2024
@Dhoeller19 Dhoeller19 requested a review from Mayankm96 August 1, 2024 16:47
@Mayankm96 Mayankm96 self-assigned this Aug 2, 2024
@Mayankm96 Mayankm96 added the bug Something isn't working label Aug 2, 2024
@kellyguo11
Copy link
Contributor

Closing as the referenced internal bug should be fixed now.

@kellyguo11 kellyguo11 closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Conda environment not being setup correctly for ZSH
4 participants