Skip to content

Disallow hook-level minimum_prek_version#1101

Merged
j178 merged 1 commit intomasterfrom
hook-level-prek-version
Nov 17, 2025
Merged

Disallow hook-level minimum_prek_version#1101
j178 merged 1 commit intomasterfrom
hook-level-prek-version

Conversation

@j178
Copy link
Owner

@j178 j178 commented Nov 17, 2025

No description provided.

@j178 j178 added the bug Something isn't working label Nov 17, 2025
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.82%. Comparing base (19e97f7) to head (32ade0b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1101      +/-   ##
==========================================
- Coverage   89.84%   89.82%   -0.02%     
==========================================
  Files          72       72              
  Lines       13417    13392      -25     
==========================================
- Hits        12054    12029      -25     
  Misses       1363     1363              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@j178 j178 force-pushed the hook-level-prek-version branch from 9271c07 to 32ade0b Compare November 17, 2025 14:00
@github-actions
Copy link

📦 Cargo Bloat Comparison

Binary size change: +0.00% (16.5 MiB → 16.5 MiB)

Expand for cargo-bloat output

Head Branch Results

 File  .text     Size          Crate Name
 0.6%   1.3% 101.3KiB          prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.6%   1.3% 100.0KiB           prek prek::builtin::pre_commit_hooks::Implemented::run::{{closure}}
 0.6%   1.2%  94.7KiB           prek prek::languages::<impl prek::config::Language>::run::{{closure}}
 0.3%   0.7%  54.6KiB           prek prek::archive::unpack::{{closure}}
 0.3%   0.6%  48.8KiB           prek prek::run::{{closure}}
 0.2%   0.5%  41.1KiB           prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.5%  39.1KiB          prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.2%   0.5%  37.3KiB regex_automata regex_automata::meta::strategy::new
 0.2%   0.4%  32.5KiB             h2 h2::proto::connection::Connection<T,P,B>::poll
 0.2%   0.4%  32.3KiB           prek prek::languages::node::installer::NodeInstaller::install::{{closure}}
 0.2%   0.4%  31.9KiB             h2 h2::proto::connection::DynConnection<B>::recv_frame
 0.2%   0.4%  31.8KiB           prek prek::workspace::Workspace::discover
 0.2%   0.4%  30.5KiB           prek prek::cli::run::run::run::{{closure}}
 0.2%   0.4%  27.6KiB           prek prek::identify::by_extension::{{closure}}
 0.2%   0.3%  25.5KiB     hyper_util hyper_util::client::legacy::client::Client<C,B>::connect_to::{{closure}}::{{closure}}::{{closure}}
 0.2%   0.3%  25.3KiB           prek prek::hook::HookBuilder::build::{{closure}}
 0.1%   0.3%  25.1KiB           prek prek::main
 0.1%   0.3%  24.9KiB     hyper_util hyper_util::client::legacy::client::Client<C,B>::send_request::{{closure}}
 0.1%   0.3%  24.6KiB           prek prek::cli::auto_update::auto_update::{{closure}}
 0.1%   0.3%  24.2KiB           prek prek::languages::golang::installer::GoInstaller::install::{{closure}}
40.7%  88.1%   6.7MiB                And 10301 smaller methods. Use -n N to show more.
46.2% 100.0%   7.6MiB                .text section size, the file size is 16.5MiB

Base Branch Results

 File  .text     Size          Crate Name
 0.6%   1.3% 101.3KiB          prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.6%   1.3% 100.0KiB           prek prek::builtin::pre_commit_hooks::Implemented::run::{{closure}}
 0.6%   1.2%  94.7KiB           prek prek::languages::<impl prek::config::Language>::run::{{closure}}
 0.3%   0.7%  54.6KiB           prek prek::archive::unpack::{{closure}}
 0.3%   0.6%  48.8KiB           prek prek::run::{{closure}}
 0.2%   0.5%  41.1KiB           prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.5%  39.1KiB          prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.2%   0.5%  37.3KiB regex_automata regex_automata::meta::strategy::new
 0.2%   0.4%  32.5KiB             h2 h2::proto::connection::Connection<T,P,B>::poll
 0.2%   0.4%  32.3KiB           prek prek::languages::node::installer::NodeInstaller::install::{{closure}}
 0.2%   0.4%  31.9KiB             h2 h2::proto::connection::DynConnection<B>::recv_frame
 0.2%   0.4%  31.8KiB           prek prek::workspace::Workspace::discover
 0.2%   0.4%  30.5KiB           prek prek::cli::run::run::run::{{closure}}
 0.2%   0.4%  27.6KiB           prek prek::identify::by_extension::{{closure}}
 0.2%   0.3%  26.9KiB          prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::HookOptions>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.2%   0.3%  25.5KiB           prek prek::hook::HookBuilder::build::{{closure}}
 0.2%   0.3%  25.5KiB     hyper_util hyper_util::client::legacy::client::Client<C,B>::connect_to::{{closure}}::{{closure}}::{{closure}}
 0.1%   0.3%  25.1KiB           prek prek::main
 0.1%   0.3%  24.9KiB     hyper_util hyper_util::client::legacy::client::Client<C,B>::send_request::{{closure}}
 0.1%   0.3%  24.6KiB           prek prek::cli::auto_update::auto_update::{{closure}}
40.7%  88.1%   6.7MiB                And 10301 smaller methods. Use -n N to show more.
46.2% 100.0%   7.6MiB                .text section size, the file size is 16.5MiB

@j178 j178 merged commit ed7c024 into master Nov 17, 2025
21 checks passed
@j178 j178 deleted the hook-level-prek-version branch November 17, 2025 14:07
j178 added a commit that referenced this pull request Nov 19, 2025
j178 added a commit that referenced this pull request Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant