Conversation
check-yaml: do not try to parse !!binary scalar into UTF-8 string
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1106 +/- ##
==========================================
+ Coverage 89.82% 89.85% +0.03%
==========================================
Files 72 72
Lines 13392 13432 +40
==========================================
+ Hits 12029 12069 +40
Misses 1363 1363 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
📦 Cargo Bloat ComparisonBinary size change: +0.61% (16.5 MiB → 16.6 MiB) Expand for cargo-bloat outputHead Branch ResultsBase Branch Results |
check-yaml: do not try to parse !!binary scalar into UTF-8 stringserde_yaml in check-yaml hook
j178
added a commit
that referenced
this pull request
Feb 2, 2026
serde-saphyr has way better error message, and it is written in safe Rust. Previous try: #1087 Previous revert: #1106 and #1112 TODO: Replace serialize_yaml_scalar with serde-saphyr as well: https://github.com/j178/prek/blob/0a4be22599076b8c6273940b2760828b442c78f4/crates/prek/src/yaml.rs#L12-L13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before I figure out how to make
serde_saphyrdeserialize into Value with bytes support, revert back to usingserde_yamlin thecheck_yamlhook.Closes #1104
Closes #1102